From 0833a6d6d34372dd0b3cbf3b5fff7b0c872cafb0 Mon Sep 17 00:00:00 2001 From: Mike D Pilsbury Date: Sun, 5 May 2024 23:29:28 +0100 Subject: [PATCH] [v3] Correct detection of npm with acceptable version (#3458) * Correct detection of npm with acceptable version * Update changelog --- mkdocs-website/docs/en/changelog.md | 1 + v3/internal/doctor/doctor_common.go | 2 ++ 2 files changed, 3 insertions(+) diff --git a/mkdocs-website/docs/en/changelog.md b/mkdocs-website/docs/en/changelog.md index fc8bc5f0655..8aaf1da7395 100644 --- a/mkdocs-website/docs/en/changelog.md +++ b/mkdocs-website/docs/en/changelog.md @@ -64,6 +64,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix registering events causing a nil map assignment by [@hfoxy](https://github.com/hfoxy) in [#3426](https://github.com/wailsapp/wails/pull/3426) - Fix unmarshaling of bound method parameters by [@fbbdev](https://github.com/fbbdev) in [#3431](https://github.com/wailsapp/wails/pull/3431) - Fix handling of multiple return values from bound methods by [@fbbdev](https://github.com/fbbdev) in [#3431](https://github.com/wailsapp/wails/pull/3431) +- Fix doctor detection of npm that is not installed with system package manager by [@pekim](https://github.com/pekim) in [#3458](https://github.com/wailsapp/wails/pull/3458) ### Changed diff --git a/v3/internal/doctor/doctor_common.go b/v3/internal/doctor/doctor_common.go index 944729bb040..4befcffe8e0 100644 --- a/v3/internal/doctor/doctor_common.go +++ b/v3/internal/doctor/doctor_common.go @@ -23,6 +23,8 @@ func checkCommonDependencies(result map[string]string, ok *bool) { if major < 7 { *ok = false npmVersion = append(npmVersion, []byte(". Installed, but requires npm >= 7.0.0")...) + } else { + *ok = true } } }