Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: inconsistent messages on eth-pm #199

Open
2 tasks
Tracked by #905
danisharora099 opened this issue Jan 30, 2023 · 6 comments
Open
2 tasks
Tracked by #905

bug: inconsistent messages on eth-pm #199

danisharora099 opened this issue Jan 30, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@danisharora099
Copy link
Contributor

danisharora099 commented Jan 30, 2023

Acceptance Criteria

waku-org/js-waku#905 is long term solution, does not need to be tracked here.

Bug Description

Messages sent and received on eth-pm seem to be highly inconsistent.

Setup is the message starting suffixed with an iterating counter, logged every 5 seconds.
It can be seen that messages are skipped when received.

browser 1:
Screenshot 2023-01-30 at 11 39 58 AM

browser 2:
Screenshot 2023-01-30 at 11 39 54 AM

This is possibly related to an upstream bug with relay, and could also be related to waku-org/js-waku#751 waku-org/nwaku#1485 waku-org/nwaku#1485 (comment)

@fryorcraken fryorcraken added this to Waku Jan 30, 2023
@danisharora099 danisharora099 added the bug Something isn't working label Jan 30, 2023
@danisharora099
Copy link
Contributor Author

Update: it is also seen that some messages are received really late and some are also repeated:

Screenshot 2023-01-30 at 11 45 07 AM

@fryorcraken
Copy link
Collaborator

Late/repeated is something already tracked on nwaku side and due to the high traffic from Status (not sure if we have an issue for it Cc @jm-clius).

Are messages truly missing or is it the rendering? You mentioned rendering.

@danisharora099
Copy link
Contributor Author

They are missed. Edited the original issue

@fryorcraken
Copy link
Collaborator

This is likely due to usage of Relay in the browser + increased traffic due to Status dogfooding.
Two actions in progress to assist:

In the mean time, do feel free to log the exact occurrences and report to nwaku team so they can investigate the missing messages.

@fryorcraken fryorcraken moved this to Triage in Waku Feb 22, 2023
@fryorcraken
Copy link
Collaborator

fryorcraken commented Mar 7, 2023

For the dupe message problem. If a message with same payload is received within gossipsub window (20s), it is dropped. If outside window, it's forwarded and hence dupe.

That could be resolved by using the hash in meta field in the eth-pm example: waku-org/js-waku#1208

@fryorcraken fryorcraken moved this from Triage to To Do in Waku Mar 7, 2023
@fryorcraken fryorcraken moved this from To Do to Priority in Waku Mar 23, 2023
@weboko weboko self-assigned this May 17, 2023
@weboko weboko moved this from Priority to In Progress in Waku May 17, 2023
@weboko weboko moved this from In Progress to Code Review / QA in Waku May 17, 2023
@weboko
Copy link
Contributor

weboko commented May 18, 2023

Temporarily closed PR waku-org/js-waku#1361
Waiting for other nodes to implement deterministic hashing
waku-org/js-waku#1233 (comment)

@weboko weboko moved this from Code Review / QA to Icebox in Waku May 18, 2023
@weboko weboko moved this from Icebox to To Do in Waku May 18, 2023
@weboko weboko moved this from To Do to Icebox in Waku May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Icebox
Development

Successfully merging a pull request may close this issue.

3 participants