Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to analyze: add new metrics #652

Closed
5 tasks
richard-ramos opened this issue Aug 18, 2023 · 1 comment
Closed
5 tasks

to analyze: add new metrics #652

richard-ramos opened this issue Aug 18, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@richard-ramos
Copy link
Member

richard-ramos commented Aug 18, 2023

In #586 @chaitanyaprem suggested the following improvements:

  • Add count of peerExchange requests handled as well.
  • Include a metric to show number of peers in peerstore
  • Disclose in and out connected peer count separately (going as a label to the connectedPeerCount?)
  • Consider maintaining discoveredNode metrics via separate counter per protocol or have a single one which gets updated with label as protocolName.
  • Duplicated proof (see chore(rln-relay): clean up nullifier table every MaxEpochGap #715 (comment))

cc: @jm-clius @alrevuelta as these metrics might make sense to be added in nwaku as well (they might even exist already, but i have not checked)

@chaitanyaprem
Copy link
Collaborator

Closing the issue as it is descoped for go-waku.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

3 participants