Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API allows usage of specific nodes for protocols #2175

Open
danisharora099 opened this issue Oct 10, 2024 · 3 comments · May be fixed by #2192
Open

feat: API allows usage of specific nodes for protocols #2175

danisharora099 opened this issue Oct 10, 2024 · 3 comments · May be fixed by #2192
Assignees
Labels
enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

Problem

Users need the ability to specify the peers used for their apps, for different protocols. Specifically for Store: https://discord.com/channels/1110799176264056863/1290694275683582085/1291644836742565929

Proposed Solution

Provide the ability to pass node multiaddrs part of node creation, similar to bootstrapNodes

Notes

  • Since we'll do this for Store, it's good to extend this API to Filter and LightPush as well. These will be optional params
@chair28980 chair28980 added this to Waku Oct 10, 2024
@weboko weboko added the enhancement New feature or request label Oct 16, 2024
@weboko weboko moved this from Triage to To Do in Waku Oct 16, 2024
@danisharora099 danisharora099 linked a pull request Oct 24, 2024 that will close this issue
3 tasks
@danisharora099 danisharora099 self-assigned this Oct 29, 2024
@weboko
Copy link
Collaborator

weboko commented Dec 9, 2024

@danisharora099 I left comments under the PR, do you want to discuss API I proposed there?

@danisharora099
Copy link
Collaborator Author

@weboko sounds good! addressed your comments on the PR

@danisharora099 danisharora099 moved this from Code Review / QA to In Progress in Waku Dec 18, 2024
@weboko
Copy link
Collaborator

weboko commented Dec 19, 2024

Use case that we try to cover here is: application developers want to use their own nodes for Store to achieve better reliability.

Usually it is more than one node - hence, I believe, we need to:

  • enable passing more than one node as preferred nodes;
  • to simplify functionality - make only these nodes being used (e.g if list is passed only these nodes are used, otherwise use TWN nodes or those discovered on a shard).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants