Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Conda for Test Environments #24

Open
MutantPlatypus opened this issue Sep 22, 2019 · 1 comment
Open

Use Conda for Test Environments #24

MutantPlatypus opened this issue Sep 22, 2019 · 1 comment

Comments

@MutantPlatypus
Copy link
Contributor

MutantPlatypus commented Sep 22, 2019

I just submitted pull request #23 to use tox for testing. I would like to build on that and use tox-conda. It would make it much easier to test across operating systems and allow new contributors to run tests locally with ease. It would also fully contain the node, npm, and git tools used in testing: It would not rely on the system installations. It also allows cairosvg to work with Windows. Tests would still be run by pytest, but conda would do all the dependency management for the test environment.

The test command would be similar to the pull request: just tox-conda instead of tox' . I would just add the nodejs and git packages to the conda dependencies.

The only downside I see is this would make miniconda a dependency for mutli-environment testing. venv and plain tox testing should still work without conda.

Edit: I got it working sooner than I expected. See PR #25.

@wallento
Copy link
Owner

Hi, thanks a lot. #25 has conflicts after I applied #23, can you please have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants