Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ksource.py #449

Closed
wants to merge 1 commit into from
Closed

Update ksource.py #449

wants to merge 1 commit into from

Conversation

djps
Copy link
Collaborator

@djps djps commented Aug 19, 2024

fixes #447

@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 71.87%. Comparing base (63055b4) to head (cbf9bdd).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
kwave/ksource.py 7.69% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   71.84%   71.87%   +0.03%     
==========================================
  Files          46       46              
  Lines        6744     6741       -3     
  Branches     1496     1495       -1     
==========================================
  Hits         4845     4845              
+ Misses       1333     1331       -2     
+ Partials      566      565       -1
Flag Coverage Δ
3.10 71.91% <7.69%> (-0.13%) ⬇️
3.11 71.91% <7.69%> (-0.13%) ⬇️
3.12 71.91% <7.69%> (-0.13%) ⬇️
3.9 71.85% <7.69%> (+0.03%) ⬆️
macos-latest 71.81% <7.69%> (+0.03%) ⬆️
ubuntu-latest 71.84% <7.69%> (+0.03%) ⬆️
windows-latest 71.85% <7.69%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djps djps added enhancement New feature or request help wanted Extra attention is needed development development tools labels Aug 19, 2024
@djps djps closed this Oct 22, 2024
@djps
Copy link
Collaborator Author

djps commented Oct 22, 2024

Closed as will be covered by another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltsims waltsims Awaiting requested review from waltsims

@faridyagubbayli faridyagubbayli Awaiting requested review from faridyagubbayli

Assignees
No one assigned
Labels
development development tools enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCE] Extend kSource to handle elastic wave propagation
1 participant
@djps