Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve p0 mutation behavior #472

Open
waltsims opened this issue Sep 19, 2024 · 1 comment
Open

[Enhancement] Improve p0 mutation behavior #472

waltsims opened this issue Sep 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@waltsims
Copy link
Owner

I also noticed, that kspaceFirstOrderxD mutates its inputs, which is not the case in the matlab version. Is this your desired behaviour?
If you run e.g. the at_array_as_sensor example with pml_inside=False, the source.p0 gets expanded, which leads to a crash in the second kspaceFirstOrder2D. To fix this we could copy some of the inputs at the beginning of kspaceFirstOrderxD.

Originally posted by @faberno in #463 (comment)

@waltsims waltsims added the enhancement New feature or request label Sep 19, 2024
@faridyagubbayli
Copy link
Collaborator

Copying will result in increased memory usage. I wonder if there is another way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants