New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self.reward_range is wrong in the file rlenv/StockTradingEnv0.py #25

Open

GuoxiangZu opened this issue Mar 14, 2021 · 0 comments

GuoxiangZu commented Mar 14, 2021

RL-Stock/rlenv/StockTradingEnv0.py

Line 28 in 22d2cbf

self.reward_range = (0, MAX_ACCOUNT_BALANCE)

" self.reward_range = (0, MAX_ACCOUNT_BALANCE) "
is wrong,
as

RL-Stock/rlenv/StockTradingEnv0.py

Line 113 in 22d2cbf

reward = 1 if reward > 0 else -100

"reward = 1 if reward > 0 else -100"
which means reward could be -100 with is below 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment