Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Role Blacklist #16

Open
jjwedemyer opened this issue Jun 27, 2018 · 12 comments
Open

[Feature Request] Role Blacklist #16

jjwedemyer opened this issue Jun 27, 2018 · 12 comments
Labels
enhancement New feature or request

Comments

@jjwedemyer
Copy link

heya,
I have some roles on my discord server, i don't want to be managed by the connector...
I think a blacklist would be the best solution for this problem.
I'll be looking into the code to see if i can possibly do this myself but feel free to stop me there :P

@warlof
Copy link
Owner

warlof commented Jun 27, 2018

Hey;

I'm interested by the specific use case. Why do you have roles that you can't manage with the connector ?
Except that; pull requests are always welcome :)

@mmolitor87
Copy link

I am used to the roles being entirely controlled by the connector from my time with Alliance Auth, since they handle it similarly, but I have wished many times for the ability to manually add roles to users without the bot stripping them away.

I'll be honest, most of the use-cases are silly. One such use is a time-out role that mutes someone if they've been 'bad'. Another time I made a 'reddit shitposter' role that turned the user's name brown, but it got annoying to keep applying the role for a joke.

A legitimate use of such a feature would be to have a bot like dynobot allow users to opt-in to roles in the event someone wants to use a bot instead of the seat-groups plugin for discord only roles that won't be re-used anywhere else. As it stands I have 14 roles in SeAT that have absolutely no permissions applied to them, just to make sure the roles in discord don't get stripped away after a user opts in.

It would be nice if the connector handled discord roles the same way it handles users - only controls the roles it knows exist. In this case since it scrapes roles, perhaps only control the roles linked in the access management.

@jjwedemyer
Copy link
Author

It would be nice if the connector handled discord roles the same way it handles users - only controls the roles it knows exist. In this case since it scrapes roles, perhaps only control the roles linked in the access management.

Either that, or just a plain blacklist.
I have a few Roles that i wouldn't want to be in the hands of the connector for leadership, who are less than a handful

@WildStrawberryEVE
Copy link

I see at least one use case for seat's bot non-touchable roles

I would like to invite people from corporations with good standing to our corporation to our discord or simply some fleet for joint fleet action.
I would like to give them some "plus/blue" role suitable for them.
Seat bot won't be able to verify them (since there is no reason for them to log into our seat) so it would strip them from roles (potentially muting them ;)
Of course I can put such "blue" role higher than bot's role in discord hierarchy which would generate some errors in logs but would work.
But If i want such role to be lower (than some roles managed by bot) than I run into a problem.

@warlof
Copy link
Owner

warlof commented Aug 16, 2018

@wildstrawberry question :
If they are not registered on SeAT, how will they get their blue access?

The bot will only track users registered from SeAT, so I don't see issue here.

@WildStrawberryEVE
Copy link

@warlof manually assigned by server admin upon arrival.
I can't request some randomly met groups who would like to join forces for one time action to register to my seat in order to get on comms. In such cases they just get invite link to discord and get manually assigned appropriate "blue" role which allows them to speak.
I guess the solution for now would be to have some separate discord channel for that where bot has no access. If that's the advised solution than it's ok.
The problem may arise when they for some reason get moved by somebody to a channel where bot operates. Than it may strip them from roles.

@WildStrawberryEVE
Copy link

Heh, just checked it the hard way.
Even though bot had no access to some channels, it had access to user list somehow. When I put it high enough, as soon as his 403 and 429 (rate limit) errors faded it started stripping everybody from roles...
So maybe it tracks users registered from seat (whatever it means) but it strips from roles everybody who has not his username mapped with discord connector.

@flyingferret
Copy link

Also would need something to these effects for my alliance coms. only thing from holding iit back from being allowed by my leadership

@tohuw
Copy link

tohuw commented Jul 9, 2019

Seems to work fine for me to have someone manually invited and assigned roles. The Discord connector doesn't mess with them. Does that mean mine is broken, or is that correct behavior?

@warlof warlof transferred this issue from warlof/seat-discord-connector Sep 8, 2019
@warlof warlof added drivers/discord Discord driver related issues enhancement New feature or request labels Sep 8, 2019
@warlof warlof removed the drivers/discord Discord driver related issues label Sep 17, 2019
@warlof
Copy link
Owner

warlof commented Mar 27, 2020

@tohuw it's correct behavior since connector isn't doing anything to not bind users.

@kevinouw
Copy link

kevinouw commented Sep 5, 2020

can we not have a role policy editor?

@warlof
Copy link
Owner

warlof commented Sep 6, 2020

what do you mean ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants