[Bug] Transfer of Discord Server Ownership is not considered

[jediefe]

Hi,

I just recently transferred our Discord server to a generic account so that every user can be treated equally by the bot which makes things easier. The initial setup was being the server owner not being identical to the SeAT administrator, as these are different persons. However, after changing the owner the owner id wasn’t updated and by looking into the source code I found this line to be the cause: https://github.com/warlof/seat-discord-connector/blob/25ac988328293e1762bb9acbc618f3b81e98bb16/src/Driver/DiscordClient.php#L253 where the id is only updated if the initial value is null.
I think it should be considered to check the owner id in every run as are all other parameters. I fixed it temporarily on my server by removing the condition.

[warlof]

Hi,

Affaict, this part is a mitigate migration thing for user running old seat-discord-connector version - since in previous versions, owner ID was not stored in the system.

Checking owner on every instance sounds like a bit massive - however, updating connector setup shoulds properly renew the owner ID https://github.com/warlof/seat-discord-connector/blob/25ac988328293e1762bb9acbc618f3b81e98bb16/src/Http/Controllers/SettingsController.php#L100