-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wasm3 compile flags #22
Comments
Thanks for the heads up, I'll take a look at this when I can. I can agree that the C-source of wasm3 is very difficult to read as it looks very opinionated style-wise with the massive amount of macro magic going on. I hope wasmi will do you well 👍 |
Thanks! Also additional note: although wasm3 supports |
@jiayihu i think we could add a flag to treat all f64 types as f32 (loosing precision), at some point. |
With #21 one can pass the propert clang flags in order to set the compilation flags in https://github.com/wasm3/wasm3/blob/master/source/m3_config.h, for instance:
Currently passing
-Dd_m3HasFloat=0
results in this error because the wasm3 signature changes:Passing
d_m3FixedHeap
, such as-Dd_m3FixedHeap=(8 * 1024)
, also results in compilation error because the(8 * 1024)
syntax is not supported by #21 .I just wanted to report the issues and causes for anyone interested. After being finally able to compile everything, I realized while I was implementing the intrinsics for
calloc, free, realloc
(required ifd_m3FixedHeap
is unset) that I was not very satisfied with the wasm3 implementation itself. Its C code is very hard to read and extend IMO. I'm ditching in favor of https://github.com/paritytech/wasmi or writing a WASM runtime myself.The text was updated successfully, but these errors were encountered: