-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge copy instructions if possible #969
Conversation
This is fixing a potential issue when merging copy instructions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #969 +/- ##
==========================================
+ Coverage 81.77% 81.81% +0.03%
==========================================
Files 262 263 +1
Lines 24378 24426 +48
==========================================
+ Hits 19936 19984 +48
Misses 4442 4442 ☔ View full report in Codecov by Sentry. |
The |
I just checked locally if |
Closes #946.
This merges two
copy
instructions to acopy2
instruction if possible.Locally I saw ~20% perf improvement for the
fibonacci/iter
benchmark test case which actually profits from this optimization since it features 2 consecutive(local.set n (local.get m))
in its.wat
code: