Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to binary protocol #43

Open
waveform80 opened this issue Sep 2, 2015 · 0 comments
Open

Transition to binary protocol #43

waveform80 opened this issue Sep 2, 2015 · 0 comments
Assignees
Milestone

Comments

@waveform80
Copy link
Member

The string protocol is nice and easy to debug, but there's enough variability in parsing time to make it a problem, at least when dealing with an array of Pi 1's (Pi 2's parsing time is almost constantly 0.2ms, Pi 1's varies between 0.4ms and 1.2ms which is enough to warrant refactoring the protocol).

The concept of the protocol can probably remain the same (a separated protocol module with class decorators used to handle parsing and construction of messages), but messages will be strictly binary. This will probably restrict data-types for parameters to something simple to handle (32-bit integer and 64-bit float only ... perhaps a one-byte for a bool). This might be a good opportunity to integrate #33 as well (make part of the header a variable length list of units?).

@waveform80 waveform80 self-assigned this Sep 2, 2015
@waveform80 waveform80 added this to the 0.5 milestone Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant