Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for a PR + new release? #272

Open
GitMensch opened this issue Jun 6, 2019 · 10 comments
Open

Time for a PR + new release? #272

GitMensch opened this issue Jun 6, 2019 · 10 comments

Comments

@GitMensch
Copy link
Contributor

The last release is 147 commits behind master and is over 18 months old.
The releases are here while current updates seem to be done (only by @BrianGladman ?) at https://github.com/BrianGladman/mpir.

@wbhart
Copy link
Owner

wbhart commented Jun 6, 2019

No one has volunteered to do the work for a release. Volunteers are welcome.

We also decided to separate Windows releases (which Brian manages) from releases for other platforms, to cut down on the work the person who is doing the release has to manage.

@GitMensch
Copy link
Contributor Author

In the meanwhile there are 161 commits mpir-3.0.0...wbhart:mpir:master and some important parts like integration of the mpf_cmp_z() function are only in master since 2018 (@BrianGladman's repo doesn't provide tags so there isn't any kind of "release" there either).

No one has volunteered to do the work for a release. Volunteers are welcome.

Given the last code change in this repo being from December 2020 (and there weren't much, those were from 2018) I'd say current master seems quite stable (= extensive testing done).

I therefore suggest to pull in the single outstanding PR (from 2022) that fixes a case where MPIR could not be built at all [I see no possible regressions], then just set the version number, Changelog and tag and call it a release.

The only thing that volunteers can do here is to suggest exactly that and, if you really like that, have the Changelog and the version number updated as a PR (pulling those and tagging needs write access to the repo).

@KevinHake
Copy link

KevinHake commented Oct 11, 2024

Some years ago I came in out of nowhere, and merged @BrianGladman's branch back into master. It was a somewhat complex set of changes requiring several passes and a lot of review. Unsurprisingly, I didn't have the trust or buy-in to persuade @BrianGladman or @wbhart to risk wasting their time with me to review/merge my pull request. Unfortunately, what happened instead was that I inflamed a bit of conflict and catalyzed the "official" split of the repo into Windows (visual studio) and non-Windows.
I wanted to say I'm sorry for that - it's something that I still often look back upon as a major personal failure. You guys have some serious credentials and math chops that are likely far above what I might accomplish in my career, tho I hope to one day achieve as much as you have. I have a lot of respect for what you've done here, and I feel bad that my only contribution may have been a step towards the end of the mpir.

Here is my best estimate of the situation (please correct me because I'm just guessing/going from memory) - Brian never really bought into the git workflow, and it's more of a waste of his energy when all he really needs at this point is a safe place to put his changes. If people find his work useful, great. Otherwise, they can leave it. As far as he's concerned, the non-Windows side shouldn't affect him.
Symmetrically, William doesn't really care what builds in Windows.
You guys have had long careers and I can see why you wouldn't want to spend any more time on menial tasks like merging/playing nice with code you'll never use, maintaining a website and changelog, tagging and testing releases and dealing with all the people that come out of the woodwork asking for help, new features, reporting bugs (that are often not bugs), etc etc.

It's maybe also worth mentioning other big contributers are no longer with us in this world for many years, so it's mostly just Brian and William left doing the majority of updates (afaik). I think it's been established they won't be doing another release themselves.

So going forward (and I'm thinking long term - like say the next 10-20 years) I see a few possibilities:

  1. @BrianGladman and @wbhart continue their separate repos and the rest of the world migrates to different libraries with official releases. Eventually the commits stop and mpir goes away (the path we're on today).
  2. Someone or a small group forks mpir and maintains releases under a new name (presumably periodically merging in @wbhart and @BrianGladman's repos)
  3. Someone or a small group is given commit access to the mpir github repo, and eventually ownership access, and potentially the old mpir.org domain, and they (potentially) kick the can a bit further down the road.

Some questions for @wbhart and @BrianGladman:

  • a) Do you still own rights to the mpir.org domain? It appears to still be registered to the same owner since 2007...
    • a1) Side note: did you know GitHub now does free hosting of static pages? I believe you can even assign it an outside domain name (i.e. mpir.org)
    • a2) Was there a mailing list or discussion page on the old website, or is that all in GitHub today? I'm remembering some old conversations we had but I'm not able to find them.
  • b) Which of the above would be your preferred path? (If you see a different one, let me know)

Personally, I've moved to Linux 100% of the time, so GMP is easier to grab (and I rarely play with this stuff lately). I'm no longer familiar with the differences between GMP and mpir besides the Windows build.
The issue I see with option 2 is Brian and William aren't likely to merge and stay in sync with a new repo, so over time merges would become more painful.
Option 3 embodies the same issue I had when I failed to reconcile the differences between Brian's and William's repos. It would be nice to have one consistent history and repo and carry on the torch.

I think a while back I might've even talked a bit about this with @GitMensch, COBOL rings a bell.
Anyhow, hi again! Cheers all!

@BrianGladman
Copy link
Contributor

BrianGladman commented Oct 11, 2024 via email

@wbhart
Copy link
Owner

wbhart commented Oct 11, 2024 via email

@KevinHake
Copy link

KevinHake commented Oct 12, 2024

Thanks for clarifying! I feel a bit better now that I understand the situation more. @wbhart by path I meant one of the 3 possibilities I listed - I think you both clarified that # 1 was the intended direction (the one you both already settled on long ago).

For @GitMensch - do you think it's worth putting together a "final release", given development is likely finished? If so, @wbhart would you be comfortable giving shared ownership to the repo to him? Or would you be more comfortable if he just branched his own repository and used that instead?

@GitMensch
Copy link
Contributor Author

GitMensch commented Oct 12, 2024 via email

@wbhart
Copy link
Owner

wbhart commented Oct 12, 2024 via email

@GitMensch
Copy link
Contributor Author

A release in a fork is not the same as an official one...

Note I am not available to help with the release.

The only thing you'd need to do is to go to https://github.com/wbhart/mpir/settings/access + provdide login + click on "add", then add people to the Maintainer list - then those can do releases and tags and accepting PRs.

@wbhart
Copy link
Owner

wbhart commented Oct 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants