Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for installing a profile without requiring kubeconfig access #1371

Closed
aclevername opened this issue Jan 31, 2022 · 1 comment
Closed

Comments

@aclevername
Copy link
Contributor

Short description
As a Profile Installer I want to be able to install a profile without having to talk to the profiles API so that users with Github access but not cluster access can install a profile

Background

As part of #1360 we add support for installing a profile:

gitops add profile --name podinfo --config-repo ssh://[email protected]/nikimanoledaki/fun-times.git --cluster test-01 --version 6.0.0 --auto-merge

This process involves querying the profiles API in-cluster to discover what the helm repository name and namespace is for the profile. To make this API call you have to have a kubeconfig setup that allows you to do a kube proxy get request to the profiles API. This means you have to have a lot of privileges to install a profile.

To allow users who only have limited access, e.g. access to the Github repo but no the cluster the ability to install clusters we should allow an option to by-pass hitting the profiles API- to do this they will have to provide us the information we get from the API, the helm repository name and namespace.

Two new flags: --helm-repo and --helm-repo-namespace (or --profile-repo and --profile-repo-namespace 🤷 )?

When these flags are set we should skip trying to hit the profiles APIs and just use the values provided. That means that the only privileges the user needs to install a profile is access to the Github repo

Acceptance criteria
As a user I should be able to run gitops add profile --name podinfo --config-repo ssh://[email protected]/nikimanoledaki/fun-times.git --cluster test-01 --version 6.0.0 --auto-merge --helm-repo foo --helm-repo-namespace bar
And it should install profile podinfo into my cluster without trying to hit the profiles API

@aclevername
Copy link
Contributor Author

@Himangini

@sympatheticmoose sympatheticmoose closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants