Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close API does not actually close the build #3969

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

9aoy
Copy link
Collaborator

@9aoy 9aoy commented Nov 14, 2024

Summary

The build is not actually closed when close() is called, only watcher was closed before.

Related Links

https://github.com/web-infra-dev/rspack/blob/8f75992e608d0e317ce94078f1b830d2d44121e6/packages/rspack/src/Compiler.ts#L646

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit cc8d827
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6735aa9a867b490008337218
😎 Deploy Preview https://deploy-preview-3969--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 65 (🔴 down 17 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title fix: close api does not actually close the build fix: close API does not actually close the build Nov 14, 2024
@chenjiahan chenjiahan merged commit e12f0f4 into main Nov 14, 2024
10 checks passed
@chenjiahan chenjiahan deleted the fix/build-watch-close branch November 14, 2024 07:55
@chenjiahan chenjiahan mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants