Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support for pkg.pr.new #7754

Closed
chenjiahan opened this issue Sep 2, 2024 · 2 comments · Fixed by #7757
Closed

[Feature]: Support for pkg.pr.new #7754

chenjiahan opened this issue Sep 2, 2024 · 2 comments · Fixed by #7757
Labels
feat New feature or request team The issue/pr is created by the member of Rspack.

Comments

@chenjiahan
Copy link
Member

What problem does this feature solve?

Add support for https://github.com/stackblitz-labs/pkg.pr.new

This enables users to access features and bug-fixes without the need to wait for release cycles using npm or pull request merges.

What does the proposed API of configuration look like?

Add GitHub actions.

@chenjiahan chenjiahan added feat New feature or request pending triage The issue/PR is currently untouched. labels Sep 2, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 2, 2024
@chenjiahan
Copy link
Member Author

I have Installed the pkg.pr.new GitHub Apps @shulaoda ❤️

@chenjiahan chenjiahan removed the pending triage The issue/PR is currently untouched. label Sep 2, 2024
@chenjiahan
Copy link
Member Author

chenjiahan commented Sep 2, 2024

We can trigger this action through comments, such as !pkg.pr.new (everyone can trigger it). This can reduce the CI overhead of Rspack repo.

Another approach is to trigger it only in the main branch, @hardfist what do you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant