Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Send Function #150

Open
tmose1106 opened this issue Sep 3, 2022 · 1 comment
Open

Async Send Function #150

tmose1106 opened this issue Sep 3, 2022 · 1 comment

Comments

@tmose1106
Copy link

I'm kinda surprised there's not more issues regarding async besides #142

Is adding an async send_async function something you would be interested in adding to the library?

I haven't worked out an implementation yet, but I'm open to doing so if there's interest in merging. Although, it would likely involve removing the requests dependency and replacing it with httpx which implements the requests interface but also provides an async client.

@jrconlin
Copy link
Member

jrconlin commented Sep 3, 2022

Not really? I mostly consider this library to be just an assist sort of thing. Anything that wanted to do heavier lifting would just call the functions in WebPusher directly. You could call Webpusher.encode() directly without going though the send bits, or fabricate your own send using that function as an example.

I can see possibly extracting the header fixup stuff from send into their own function, but those tend to be a bit specific for the push transaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants