Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to send empty push notification ? #96

Open
arpit728 opened this issue Sep 2, 2019 · 4 comments
Open

How to send empty push notification ? #96

arpit728 opened this issue Sep 2, 2019 · 4 comments

Comments

@arpit728
Copy link

arpit728 commented Sep 2, 2019

How can I send an empty push notification, currently it gives NPE I want to do this for compatibility with chrome versions below 49.
@martijndwars
Copy link
Member

Can you share the stack trace of the NPE?

@arpit728
Copy link
Author

arpit728 commented Sep 2, 2019

@martijndwars

One more thing I would like to highlight here, for chrome version below 49, subscription object only contains endPint and not the encryption keys. But this library always tries to encrypt, how to deal with this?

@martijndwars
Copy link
Member

That would be a bug, thanks for reporting. Do you want to work on a PR? Otherwise, I may be able to take a look this weekend.

@arpit728
Copy link
Author

arpit728 commented Sep 3, 2019

@martijndwars
Cool, I would take up this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martijndwars @arpit728