Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use underscores in names of producers #35

Open
bradenpecora opened this issue Sep 12, 2022 · 0 comments
Open

Can't use underscores in names of producers #35

bradenpecora opened this issue Sep 12, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers parking lot

Comments

@bradenpecora
Copy link
Collaborator

bradenpecora commented Sep 12, 2022

Currently, the type of a producer can't contain underscores. It won't raise any errors, but things will not be plotted correctly as a result of the string matching used. Specifically, here is why: https://github.com/bradenpecora/HOwDI/blob/8392fb5cd335d43f96a51522c907dab4c050c06c/HOwDI/postprocessing/generate_outputs.py#L71-L76

If a producer is named/named before_after, the corresponding key in the returned dict will be before. It should be before_after.

I don't intend to fix this anytime soon, but someone can make a PR if they like. There should be a warning at the very least.

@bradenpecora bradenpecora added bug Something isn't working good first issue Good for newcomers parking lot labels Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers parking lot
Projects
None yet
Development

No branches or pull requests

1 participant