We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, the type of a producer can't contain underscores. It won't raise any errors, but things will not be plotted correctly as a result of the string matching used. Specifically, here is why: https://github.com/bradenpecora/HOwDI/blob/8392fb5cd335d43f96a51522c907dab4c050c06c/HOwDI/postprocessing/generate_outputs.py#L71-L76
If a producer is named/named before_after, the corresponding key in the returned dict will be before. It should be before_after.
before_after
before
I don't intend to fix this anytime soon, but someone can make a PR if they like. There should be a warning at the very least.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Currently, the type of a producer can't contain underscores. It won't raise any errors, but things will not be plotted correctly as a result of the string matching used. Specifically, here is why: https://github.com/bradenpecora/HOwDI/blob/8392fb5cd335d43f96a51522c907dab4c050c06c/HOwDI/postprocessing/generate_outputs.py#L71-L76
If a producer is named/named
before_after
, the corresponding key in the returned dict will bebefore
. It should bebefore_after
.I don't intend to fix this anytime soon, but someone can make a PR if they like. There should be a warning at the very least.
The text was updated successfully, but these errors were encountered: