-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Attribute not in html tag #166
Comments
You're referring to XHTML in your example there in conjunction with the language attribute. These are two separate concepts :)
I am happy to add in the language attribute, please send through a Pull Request :)
…Sent from my iPhone
Please excuse my brevity
On 5 Jan 2017, at 11:00 pm, jg-development ***@***.***> wrote:
Hi,
the main templates does not have the lang attribute in the html tag.
Instead of:
<!DOCTYPE html>
<html>
it should be something like that
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php echo $this->getLang() ?>" lang="<?php echo $this->getLang() ?>">
Greetings Jan
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
jg-development
added a commit
to jg-development/magento-boilerplate
that referenced
this issue
Jan 5, 2017
This closes ths issue webcomm#166
In that case .... I created a pull request for the lang attribute only |
jg-development
added a commit
to jg-development/magento-boilerplate
that referenced
this issue
Jan 5, 2017
This closes ths issue webcomm#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
the main templates does not have the lang attribute in the html tag.
Instead of:
it should be something like that
Greetings Jan
The text was updated successfully, but these errors were encountered: