Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Participant Video Size Issue #123

Open
hirenpatel8891 opened this issue Apr 26, 2022 · 3 comments
Open

Remote Participant Video Size Issue #123

hirenpatel8891 opened this issue Apr 26, 2022 · 3 comments

Comments

@hirenpatel8891
Copy link

I am using upgrading Cisco SDK V2(2.8.0) to V3(3.4.0) version from my application. We have requirement of displaying full screen video for the remote participant. In previous version of V2 we are getting video view of entire screen but now with the upgrading the Cisco SDK to 3.4.0, We found that video view displaying empty space on top and bottom of the side. Same issue we are facing for local view as well which displaying empty space.

We have tried the changing the value of the property "remoteVideoRenderMode" to stretchFill as well but nothing is happening.

I have attached the screenshot for the same in which green view display the empty space for remote video view.
IMG_0234

Please check and suggest the solution

@sandiban
Copy link

sandiban commented Apr 26, 2022

Hi @hirenpatel8891

This is Sandip from Webex API & SDK Dev Support team.
I tested and shared the screen shot here from my outcome and to let you know, I've not been able to reproduce the issue.
For me, the participant's video as well as my video, both are coming with full screen (you can see the details in the attached screen shot)
By the way, I tested this entirely on 2 iPhone 11 devices and used the Webex JS SDK sample for test with the v3.4.0 - https://github.com/webex/webex-ios-sdk-example
Can I ask you to reproduce the same from the test sample and let us know if this is still reproducible.
Because we don't how you've setup your code and to be on a common ground, it'd be very helpful if you can reproduce this on the test sample.
By the way, I was using the Video Render Mode as Fit during my test.
Also, could you share us the complete remoteVideoRenderMode function to understand your code.

Since it requires more discussion (may be) going ahead, can I ask you to share the details to [email protected] and there we can discuss further about it. That'd be easiest way to extend the communication.

IMG_2828

@hirenpatel8891
Copy link
Author

Thanks for the reply

The screenshot which I have attached has a full screen view which has same size a device hight and width. Its working fine in the iPhone8 but this empty space issue is coming for device iPhone XR, iPhone 13.

I have tried to reproduce the same issue in the Kitchen Sink application. In the kitchen sink application code I have updated the size of the remote video to full screen. I have also attached the screenshot for it here taken from kitchen sink app.
IMG_0236

Here is my implementation for the remoteVideoRenderMode. After connecting to the call I am setting the video render mode value on onConnected callback.

    call.onConnected = { [weak self] in
        guard let self = self else { return }
        DispatchQueue.main.async {
            call.videoRenderViews = (self.selfVideoView, self.remoteVideoView)
            call.remoteVideoRenderMode = .stretchFill
            self.nameLabel.text = call.title
            self.callingLabel.text = "On Call"
        }
    }

I have tried all three values (.stretchFill, .fit, cropFill) for remoteVideoRenderMode but it has same behaviour. I have tried same with kitchen sink app to changes this mode and It also have a same behaviour.

Thanks.

@jbenyovs
Copy link

@hirenpatel8891 replied in the support ticket you opened for this (#108655).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants