SSH config cleanup not done

[kcarlson]

The modified git config is not cleaned up after a run, e.g. the url git@key- section.
This will affect a subsequent run on, for example, a self-hosted runner.

We are using a workaround which may help someone:

- name: Restore git global config
  if: always()
  run: |
    MATCH=$(grep -o 'git@key-[^"]*\.github\.com:.*/[^"]*' ~/.gitconfig)
    git config --global --remove-section url.${MATCH}

[ILikeYourHat]

@kcarlson would this workaround also work when multiple keys are provided?

[kcarlson]

I've only tested it with a single key being provided to the ssh-private-key field. If multiple keys end up under the same section in the .gitconfig, it should work, otherwise, if there are multiple sections, MATCH will have multiple matches and the ´git config´ command will not work.

[tonynajjar]

I also have this issue, any news?

[dcasnowdon]

This is causing problems here too. It'd be great to have a resolution if one is available.

[rickyjames35]

Thanks @kcarlson, your work around did the trick.
I'm noticing a section at the end of my action called "Post Add SSH Key"

Post job cleanup.
Stopping SSH agent
The "file" argument must be of type string. Received undefined
Error stopping the SSH agent, proceeding anyway

I'm wondering if this should be cleaning up the global gitconfig but is failing.
Either way the work around gets the job done. Thanks.

[SMillerDev]

I have the same issue about the file argument. We're running this on self-hosted macs. Did you find a fix @rickyjames35 ?

[Kemmotar2]

Same error on self hosted. Doing a manual clean up cloud work? like:

• name: Manually Stop SSH agent
  run: |
  eval "$(ssh-agent -k)"

  haven't tested just an idea

[makalu79]

We have the same problem on self-hosted windows runners where we can't use docker due to GitHub not supporting it. I wrote this step which did the trick for us as we're not working with per-user gitconfig:

- name: Reset Git config
  if: always()
  run: |
    Clear-Content "$env:USERPROFILE\.gitconfig"

It's a real pity that this does not work out of the box. I agree with @rickyjames35 that this error message could explain why the cleanup is not done, we get the same message in our logs.