-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERR_CONNECTION_RESET, When will upload via chunks be available? #11
Comments
I believe chunks upload is to enable pause / resume and not sure if that would solve uploading large files. Don't have plans for implementing this atm, put would welcome any contributions, |
Hey, thanks for the response. I'll look into it and if I find a solution I'll contribute. |
@websemantics I forgot to get back to you, but I created a typescript project based off of your vimeo-upload. It uploads purely by chunks (and updates the chunk size based on the connection speed). If you're interested in using it, I could eventually submit a pull request. It could be seen a v2 of your original project. However, I'd have to change a few things to make it more dynamic. |
Hi @rugdealer, |
@websemantics I'll prepare an easier version to use. I'll keep you posted. In the index.html, it's pretty much the same thing you do.
Edit Yeah, i'll add some interfaces and make it all round cleaner. I'm using a cleaner version for the company. It works well. Tested it with a 20g file without getting any errors. |
I am also using a slightly modified version of vimeo-upload in production and am very interested in the ability to upload via chunks. Right now not all my client's large file uploads go through, most often on the clients with poorer internet connections. I'd be happy to put together a PR, let me know. |
I will look forward to your PR @rugdealer, this is exciting 👍 |
I'll definitely wait, but just letting you know I'll be testing and possibly pushing to production when ready, so can help out whenever needed. |
I've modified quite a bit with the project. I'm currently debugging and I expect the first version of the project to be finished in a few days. How should we handle the PR? Should a branch be created? The tricky part is, it's a project started from scratch so it uses a completely different .git. Should the project be completely separate and renamed "vimeo-chunk-upload" ? Please let me know what you think would be best @websemantics thanks. EDIT: I also need to finish documentation and code commenting. |
@rugdealer, I don't mind having own fork I've created a new branch If you do go with the later, make sure you add yourself to the authors list (i.e. package.json etc) as this is a major contribution and since your help will also be needed to fix any bugs :) |
@websemantics ok great. I've forked the project and started adding the changes. I'll send the pull request in a few days to your |
Unsure if the two are related, however on some computers I'm getting an ERROR_CONNECTION_RESET while uploading videos that are greater than 2-3G via Chrome.
There is a way to fix this via Chrome, however it's not very user-friendly since I'm looking to create a video uploader for video contributors to my channel.
When will the upload via chunks be available ? Would be nice to catch this error and switch to upload via chunks?
Thanks !
The text was updated successfully, but these errors were encountered: