Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordmove not copying file in wp-content #214

Open
defaria opened this issue Sep 8, 2015 · 16 comments
Open

Wordmove not copying file in wp-content #214

defaria opened this issue Sep 8, 2015 · 16 comments
Assignees

Comments

@defaria
Copy link

defaria commented Sep 8, 2015

I use a plugin called Login Logo, which looks for an image in the wp-content folder called login-logo.png, and then sets that image as the login logo. On 3 different websites wordmove failed to copy that image over. The only excluded settings I have for wp-content is the one that comes by default with the movefile.

"wp-content/*.sql"

Has anyone else noticed issues copying files from wp-content?

Just to be clear... other folders inside wp-content are copied just fine. But the .png image is the only actual file I have in there.

@alessandro-fazzi
Copy link
Member

It could be useful in these cases to report the command you are issuing to Wordmove.

Anyway: I think this is related to #163 and is a design issue. -w flag pushes the core excluding wp-content/*, other flags keep care of the directories inside wp-content. This way we don't care about files inside wp-content.

Your case is someway exotic IMHO, since your plugin searches for something in a non standard path and in a non standard way (save here an image and I will search for it is a really weak approach from my POW).

I'd like anyway to continue the discussion together with @luisbraga and poll you a bit about what should Wordmove be doing different from the actual behaviour.

@defaria
Copy link
Author

defaria commented Sep 10, 2015

Thanks @pioneerskies. I was simply doing a pull --all , to get a copy of the site down to local.

@Mark-William-Schumacher

I'm also experiencing a missed upload when i push with
"wordmove push -e staging --all"

The newly added files in /wp-content/webfonts/ are all missing from the upload.

The issue was resolved when i put the webfonts folder into /wp-content/uploads/webfonts/ instead.

@filipvanreeth
Copy link

Hi, i have the same problem. The wp-content folder with it's content is not getting pushed to the development version in my case. I use the command wordmove push -e staging --all and i'm using the default Movefile file.

Anything I'm doing wrong?

@vojtabiberle
Copy link

Hi. I have same problem with nextgen-gallery. Files in wp-content/gallery are not synced.

@mukkoo
Copy link

mukkoo commented Apr 11, 2016

Wordmove doesn't sync all directories inside wp-content/ but only languages, themes, plugins and mu-plugins. This can be a feature?

@filipvanreeth
Copy link

Thanks. That would be nice

Sent from my iPhone

On 11 Apr 2016, at 18:26, Filippo Gangi Dino [email protected] wrote:

Wordmove doesn't sync all directories inside wp-content/ but only languages, themes, plugins and mu-plugins. This can be a feature?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub

@mukkoo mukkoo added this to the v.2.1.0 milestone Apr 12, 2016
@alessandro-fazzi alessandro-fazzi modified the milestones: v2.2.0, v.2.1.0 Feb 18, 2017
@alessandro-fazzi alessandro-fazzi removed this from the v2.2.0 milestone Dec 12, 2017
@alexanderkladov
Copy link

alexanderkladov commented Apr 28, 2018

Hi,

I was trying to figure out why my wp-content/index.php wasn't syncing over between environments and came across this thread. I have that file for security reasons (i.e. silence is golden). And after reading this, I've realised that my Wordmove is also adding wp-content/* to my exclude array, even though I didn't add that to movefile.yml.

Why was this removed from the v2.2.0 milestone and how can I prevent that from happening?

Is there a way to force Wordmove to sync absolutely everything, except for what's specified in exclude array?

Also, while on the topic of excludes: how can I ignore a file ONLY in root wp directory? I've tried ./filename & /filename, but neither one worked..

Cheers,
Alex

@ihorvorotnov
Copy link

Wordmove doesn't sync all directories inside wp-content/ but only languages, themes, plugins and mu-plugins. This can be a feature?

I can understand this design decision. However, it misses some 'core' files, for example, drop-ins:

path/file description
wp-content/object-cache.php external object cache class
wp-content/advanced-cache.php alternative cache class
wp-content/db.php custom db class
wp-content/db-error.php custom db error message
wp-content/install.php custom installation routine
wp-content/maintenance.php custom maintenance mode message
wp-content/sunrise.php multisite preloader
wp-content/blog-deleted.php custom message if a multisite blog was deleted
wp-content/blog-inactive.php custom message if a multisite blog was set inactive
wp-content/blog-suspended.php custom message if a multisite blog was suspended
wp-content/$locale.php is loaded for a specific locale in use

Also, the wp-content dir itself is considered as a directory to keep everything that's 'user generated content' or not plugin/theme. That is the base purpose of the dir. Custom dirs within wp-content are a common practice, especially in custom development setups with Composer and modern approaches.

Basically, I'd expect to find anything inside the wp-content dir. That's what it is for.

@alessandro-fazzi
Copy link
Member

@alexanderkladov about this

Also, while on the topic of excludes: how can I ignore a file ONLY in root wp directory? I've tried ./filename & /filename, but neither one worked..

It was hopefully fixed in 1642065

@alessandro-fazzi
Copy link
Member

@alexanderkladov @ihorvorotnov

I'm re-lucubrating about this feature, but let me ask you an advice/opinion: what kind of interface do you expect to push the wp-content's files? Would you like to write down a couple user stories? E.g.:

  • when I push or pull --all I want wordmove to sync all .php files inside wp-content
  • when I push --wordpress I want wordmove to sync all .php files inside wp-content (?)
  • I want to have a --unicorn flag that will push only files and folder inside wp-content

(examples are contradictory on purpose)

Let me understand your usage expectation to help me out imagine how to implement such a feature :)

@ihorvorotnov
Copy link

@pioneerskies I'm new to Wordmove (like, couple days new) so I don't have any preferred way yet. Based on logic and previous experience with other tools/techs, I'd be happy with the default option to move entire wp-content and exclude only dirs/files that are specifically listed in the config.

@alexanderkladov
Copy link

alexanderkladov commented Nov 1, 2018

@pioneerskies I agree with @ihorvorotnov, push everything in wp-content or even root website folder, unless specifically excluded in movefile.yml. Just like what Git would do (i.e. if it's not in .gitignore, it's pushed to the repo).

@kauaicreative
Copy link

wordmove pull --content could work.
Google's new plugin/theme stores style data in /wp-content/assets/css/front-end-compiled.css
https://wordpress.org/plugins/material-design/

@kauaicreative
Copy link

kauaicreative commented Feb 11, 2022

Being able to push pull a custom directory in wp-content would be ideal wordmove pull --custom=cache

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants