Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare_tei_works script fails when fetching Swagger #2705

Open
paul-butcher opened this issue Sep 9, 2024 · 2 comments
Open

compare_tei_works script fails when fetching Swagger #2705

paul-butcher opened this issue Sep 9, 2024 · 2 comments

Comments

@paul-butcher
Copy link
Contributor

paul-butcher commented Sep 9, 2024

compare_tei_works.py fetches swagger.json in order to define the list of includes fields to append to the the works requests it makes.

Here:

includes = client.get("/swagger.json").json()["paths"]["/works/{id}"]["get"][

The resource: https://api.wellcomecollection.org/catalogue/v2/swagger.json does not exist and returns a 404 with the following body:

{"errorType":"http","httpStatus":404,"label":"Not Found","description":"Page not found for URL /catalogue/v2/swagger.json","type":"Error"}

This causes the script to abort.

@paul-butcher
Copy link
Contributor Author

I suspect this script has not been used for over two years, otherwise it would have been spotted when we removed the autogenerated swagger

@kenoir
Copy link
Contributor

kenoir commented Sep 16, 2024

Maybe we just bin this script then, if we need it again we can resurrect or re-write?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants