Skip to content

Latest commit

 

History

History
28 lines (18 loc) · 1.77 KB

README.md

File metadata and controls

28 lines (18 loc) · 1.77 KB
Raw

GitHub Process

See How we work in Notion for a view on team processes.

Language used: Projects, Issues & Pull Requests (PRs)

Projects, Issues & PRs overlap in GitHub, here is how we think about them:

  • Projects are quarterly iterations of the projects available in Github.
  • Issues & PRs are both change requests.
  • A PR is the unit of deployment, i.e. PRs should be deployable in isolation (where possible).
  • PRs reference a set of git commits which in totality describe a coherent functional change.
  • Issues reference one or more PRs which together describe a coherent functional change.
  • Github Projects contain Issues or PRs which transition through defined states towards done.

Processes

As a team, we operate in a very friendly, trusted, no-blame culture. The nature of code review can sometimes make this feel a little bit difficult, especially if you're a new joiner.

That's why we hope documenting our standards for both pull request and code review processes will help in strengthening our confidence and interpretation of them. We also hope it helps empower new joiners in tackling their first code reviews, or submitting their first feature.

We're approaching this from a place of believing code review to be an excellent learning tool. Both for the submitter, who benefits from suggestions on their PR, but also for the reviewer. It's a prime place to ask questions, and learn from the submitter themselves.

So have a look through, and feel free to submit changes. In order: