parsers: whois.cira.ca: Add new version support for 2019 whois output #131
Conversation
Most recent whois output from CIRA, with year 2019, has a very different output than what was expected in the past. This adds support for it while keeping support for previous versions of the whois output.
|
Looking good! Fixes #126. |
|
I'm finding that this fix is needed for the .ca domains. If we're not comfortable with the fix in #130, Is it possible to move the fix for the unterminated (with newline lines into the parser ( def content_for_scanner
super
@content_for_scanner << "\n" unless @content_for_scanner.end_with?("\n")
@content_for_scanner
endHow can we move this PR forward? |
|
Thanks for this @XaF, for the record I ended up starting my fork in which I merged some of the pending PRs and provided more fixes. I didn't cherry-pick your PR here because it was keeping a lot of legacy code and adding on top, instead I refactored the parser to use the standard ICANN Compliant parser and updated all tests in ed7068c. There's no reason to keep supporting the outdated version (unless you see one?), gem 'whois-parser', github: 'jarthod/whois-parser' # Unofficial but more up-to-date fork, check status at https://github.com/jarthod/whois-parser |
Most recent whois output from CIRA, with year 2019, has a very different
output than what was expected in the past. This adds support for it
while keeping support for previous versions of the whois output.
This requires the changes introduced in PR #130 to work properly (as issue with the missing new line otherwise).
Fixes #126