From 03c74f47321891e6cb2ebf4e3760102d2dc4c5ef Mon Sep 17 00:00:00 2001 From: Salma Alam-Naylor Date: Fri, 15 Nov 2024 12:23:39 +0000 Subject: [PATCH 1/5] Add support for bluesky urls with one test case --- src/components/Person.js | 18 ++++++++++++++---- src/data.js | 3 ++- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/components/Person.js b/src/components/Person.js index 6190444a4..09cfcf0ba 100644 --- a/src/components/Person.js +++ b/src/components/Person.js @@ -96,16 +96,26 @@ export default function Person({ person }) { {/* If they have a mastodon, and no twitter, show that */} {person.mastodon && !person.twitter && (
- + rel="noopener noreferrer"> @ {mastodonHandle}
)} + + {/* If they have a bluesky, and no mastodon and no twitter, show that */} + {person.bluesky && !person.mastodon && !person.twitter && ( +
+ + @ + {person.bluesky} + +
+ )} ); diff --git a/src/data.js b/src/data.js index 71efba1f7..45f2c3d48 100644 --- a/src/data.js +++ b/src/data.js @@ -8,6 +8,7 @@ * @property {string} country - flag emoji for contributor's country * @property {string} [twitter] - optional Twitter username (beginning with `@`) * @property {string} [mastodon] - optional Mastodon username & server (beginning with `@`, ex: `@hello@mastodon.social`) + * @property {string} [bluesky] - optional Bluesky (bsky.app) handle (do not use `@`) * @property {string} [emoji] - some emoji corresponding to the contributor * @property {'apple' | 'windows' | 'linux' | 'bsd'} [computer] * @property {'iphone' | 'android' | 'windowsphone' | 'flipphone'} [phone] @@ -3844,7 +3845,7 @@ module.exports = [ name: 'Salma Alam-Naylor', description: 'I write code for your entertainment.', url: 'https://whitep4nth3r.com/uses', - twitter: '@whitep4nth3r', + bluesky: 'whitep4nth3r.com', emoji: '⚡️', country: '🇬🇧', computer: 'apple', From 239788d048c73c7bc9e948a05c0932e7c2d85347 Mon Sep 17 00:00:00 2001 From: Salma Alam-Naylor Date: Fri, 15 Nov 2024 12:25:40 +0000 Subject: [PATCH 2/5] Try and make the file formatted in the same way as it was previously --- src/components/Person.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Person.js b/src/components/Person.js index 09cfcf0ba..a35d3e341 100644 --- a/src/components/Person.js +++ b/src/components/Person.js @@ -96,7 +96,7 @@ export default function Person({ person }) { {/* If they have a mastodon, and no twitter, show that */} {person.mastodon && !person.twitter && (
- @ From 27551568673daffd18904926ef8bdea605f75cc8 Mon Sep 17 00:00:00 2001 From: Salma Alam-Naylor Date: Fri, 15 Nov 2024 12:26:47 +0000 Subject: [PATCH 3/5] Try and make the file formatted in the same way as it was previously --- src/components/Person.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/components/Person.js b/src/components/Person.js index a35d3e341..883417589 100644 --- a/src/components/Person.js +++ b/src/components/Person.js @@ -85,8 +85,7 @@ export default function Person({ person }) { + rel="noopener noreferrer"> @ {person.twitter.replace("@", "")} @@ -98,7 +97,8 @@ export default function Person({ person }) {
+ rel="noopener noreferrer" + > @ {mastodonHandle} @@ -108,9 +108,10 @@ export default function Person({ person }) { {/* If they have a bluesky, and no mastodon and no twitter, show that */} {person.bluesky && !person.mastodon && !person.twitter && (
- + rel="noopener noreferrer" + > @ {person.bluesky} From 247b0f3c3cc1c8ad9df85469b2284ed5f40d5d49 Mon Sep 17 00:00:00 2001 From: Salma Alam-Naylor Date: Fri, 15 Nov 2024 12:27:23 +0000 Subject: [PATCH 4/5] More formatting --- src/components/Person.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/Person.js b/src/components/Person.js index 883417589..4e2a88b96 100644 --- a/src/components/Person.js +++ b/src/components/Person.js @@ -85,7 +85,8 @@ export default function Person({ person }) { + rel="noopener noreferrer" + > @ {person.twitter.replace("@", "")} From 337da1d179996826d35a4376e262ff371cee2328 Mon Sep 17 00:00:00 2001 From: Salma Alam-Naylor Date: Fri, 15 Nov 2024 12:28:05 +0000 Subject: [PATCH 5/5] More formatting --- src/components/Person.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/Person.js b/src/components/Person.js index 4e2a88b96..21039a9f4 100644 --- a/src/components/Person.js +++ b/src/components/Person.js @@ -96,7 +96,8 @@ export default function Person({ person }) { {/* If they have a mastodon, and no twitter, show that */} {person.mastodon && !person.twitter && (
-