Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplicate code for exception handling #37

Open
elfring opened this issue Jun 28, 2022 · 3 comments
Open

Reduce duplicate code for exception handling #37

elfring opened this issue Jun 28, 2022 · 3 comments

Comments

@elfring
Copy link

elfring commented Jun 28, 2022

The statement “print_error("Memory Allocation problem");” is specified in three branches for the implementation of the function “verify_write”.
I find that the message should be sufficient at one source code place.
💭 This could be achieved if a corresponding jump label like “report_allocation_failure” will be applied, couldn't it?

@arthur-simchaev-wdc
Copy link
Contributor

Correct.
Do you want fix it & submit PR? If not I will change it

@elfring
Copy link
Author

elfring commented Jun 29, 2022

💭 I would find it nice if you could integrate the proposed change possibilitiy also directly (without another separate pull/merge request from me).

@arthur-simchaev-wdc
Copy link
Contributor

arthur-simchaev-wdc commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants