Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching issue causing an error loading the Magnific Popup plugin #1160

Open
tanahel-udem opened this issue May 13, 2024 · 7 comments
Open

Caching issue causing an error loading the Magnific Popup plugin #1160

tanahel-udem opened this issue May 13, 2024 · 7 comments

Comments

@tanahel-udem
Copy link

The following error sometimes show up making the magnific popup unresponsive. The error shows up on v5.0.0 after refreshing the page. A hard refresh normally solves the issue. The error is present on the sample page: https://cdts.service.canada.ca/app/cls/WET/gcintranet/v5_0_0/cdts/samples/gctoolsmodal-en.html#gctools

 Uncaught TypeError: Cannot read properties of null (reading 'insertBefore')
    at e.yepnope.injectJs (wet-boew.js:1972:7686)
    at wet-boew.js:1972:4461
@ahmad-shahid
Copy link
Contributor

Hello, what steps would I have to take to reproduce this error?

@tanahel-udem
Copy link
Author

On Edge version 124.0.2478.97

  1. Go to the gctoolsmodal sample.
  2. Open the console.
  3. Refresh the page multiple times until the error shows up.
  4. Once the error is logged try opening the GCTools and notice no popups open.

@ahmad-shahid
Copy link
Contributor

We'll take a look at this as soon as we get the new Edge update.

@chyne
Copy link

chyne commented Jun 15, 2024

We're seeing similar issue in 4.0.47 (in Chrome):

TypeError: Cannot read properties of null (reading 'insertBefore')
at e.yepnope.injectJs (wet-boew.js:1947:7686)
at wet-boew.js:1947:4461

In our case we noticed thanks to intermittent reports of DataTables AJAX call not firing. First reports started coming around the time this issue was opened.

@chyne
Copy link

chyne commented Jun 15, 2024

I am also able to reproduce this issue on the 4.0.47 page:
https://cdts.service.canada.ca/app/cls/WET/gcintranet/v4_0_47/cdts/samples/gctoolsmodal-en.html#gctools

Chrome 125.0.6422.142

@chyne
Copy link

chyne commented Aug 1, 2024

I can even reproduce the issue on the CDTS home page: https://cenw-wscoe.github.io/sgdc-cdts/docs/index-en.html

Uncaught 
TypeError: Cannot read properties of null (reading 'insertBefore')
    at e.yepnope.injectJs (wet-boew.js:1999:7686)
    at wet-boew.js:1999:4461

CDTS/WET fails to load and all WET/CDTS functionality is broken (example, menu doesn't load):

image

@chyne
Copy link

chyne commented Aug 1, 2024

This might be an extension issue. In the WET repo a user reported a similar issue that they traced to VueJS extension. In my case LastPass extension seems to have been the issue. Removing and re-installing it to force an update to a newer version seems to have resolved it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants