Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of bases without translations #1319

Closed
rolandgeider opened this issue May 7, 2023 · 1 comment · Fixed by #1342
Closed

Better handling of bases without translations #1319

rolandgeider opened this issue May 7, 2023 · 1 comment · Fixed by #1342
Milestone

Comments

@rolandgeider
Copy link
Member

rolandgeider commented May 7, 2023

If a base has no translations many things can break (#1269, wger-project/flutter#359).

While ideally this shouldn't happen, we could handle this better:

  • In the exercisebaseinfo only iterate over the bases with translations
  • Add a check that sees if the exercises have problems (error when no translations and warning when no English ones?), see core/checks.py
  • Make the submission process more robust so that this can't happen
  • Make sure the search also doesn't break
@rolandgeider
Copy link
Member Author

started adding custom managers that automatically filter out exercises without translations. Still need to test this a bit and see if there are some performance problems

@rolandgeider rolandgeider added this to the 2.2 milestone Jun 6, 2023
@rolandgeider rolandgeider linked a pull request Jun 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant