Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: RemoveDo is incomplete #1034

Open
akimd opened this issue Aug 7, 2024 · 2 comments
Open

Doc: RemoveDo is incomplete #1034

akimd opened this issue Aug 7, 2024 · 2 comments

Comments

@akimd
Copy link
Contributor

akimd commented Aug 7, 2024

Hi,

That's a very minor detail, but it might be worth fixing for sake of newcomers. The RemoveDo example does not recurse in the body of while loops, so it fails to process nested loops.

Adding a super should suffice.

Cheers!
@akimd
Copy link
Contributor Author

akimd commented Aug 7, 2024

(Also, FWIW, using <<-RUBY rather than EOF is more conformant to RuboCop's recommended practice.)

@akimd
Copy link
Contributor Author

akimd commented Aug 7, 2024

Also, the doc pointed to, https://whitequark.github.io/parser/, is completely outdated. Maybe it could be updated automatically using GitHub actions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akimd