Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commenting in html #5

Open
ivancuric opened this issue Aug 8, 2016 · 5 comments
Open

commenting in html #5

ivancuric opened this issue Aug 8, 2016 · 5 comments
Assignees
Milestone

Comments

@ivancuric
Copy link

The auto comment / blockcomment is wrong. It just uses the default HTML comment instead of {##}

@wholroyd wholroyd added this to the v0.0.8 milestone Aug 27, 2016
@wholroyd wholroyd self-assigned this Aug 27, 2016
@wholroyd
Copy link
Owner

Thanks for reporting the issue. This came up once before and while I couldn't figure out how to wrap with a block comment, I had just made a decision to remove the commenting to let lower languages handle the comment. Once I figure out how vscode does block comments when invoking line comment/auto comment, then I can incorporate it.

@wholroyd wholroyd modified the milestones: 1.0, v0.0.8 Nov 21, 2016
@darkvertex
Copy link

Hello!

Discovered a commenting HTML bug first hand myself today when trying to comment some CSS lines in an HTML file within a <style> block.

Without this extension, VSCode properly uses /* style */ but with this extension loaded, I always get <!-- style --> which is illegal CSS and thus breaks the whole <style> block. 👎

Any thoughts or ideas?

@guyskk
Copy link

guyskk commented Mar 17, 2018

@darkvertex @wholroyd I meet the same problem, I think vscode-jinja should not add grammar to *.html files, it should only deal with *.j2(or *.jinja2) files. I didn't meet the problem in vscode-mako since it only deals with *.mako fills.

@tim0991
Copy link

tim0991 commented Apr 4, 2018

@darkvertex @wholroyd comment inline script with same error

<script>

//var a = 123; before enable

<!-- var a = 123; after enable -->

</script>
``

@miversen33
Copy link

I have no thing to add to this besides the fact that it still exists. I have had to uninstall the extension because commenting embedded js/css just doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants