Fix #19 #22
Closed
Fix #19 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gx.GetPackageRoot()` uses `os.Getwd()`, but unlike the cwd variable, it doesn't use `filepath.EvalSymlinks`. Now it's output is fed to `filepath.EvalSymlinks` to fix the problem occuring in whyrusleeping#19.
main.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| lroot, err := filepath.EvalSymlinks(lroot) |
There was a problem hiding this comment.
don't you mean to use mroot here?
There was a problem hiding this comment.
Yes I do. I will update the PR.
|
@lgierth mind reviewing this? I don't use symlinks in my workflow at all |
|
Fixed in #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #19 in a way consistent with the current code.
I think the issue was caused by the fact that the
gx.GetPackageRoot()function usesos.Getwd()but doesn't evaluate symlinks.The desired behaviour as illustrated by the top-level
cwdvariable is to evaluate symlinks after usingos.Getwd().This pull request makes this behaviour consistent by evaluating symlinks in
gx.GetPackageRoot()'s output.