Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Banana return the language that was selected? #17

Open
davidbarratt opened this issue Aug 14, 2019 · 0 comments
Open

Should Banana return the language that was selected? #17

davidbarratt opened this issue Aug 14, 2019 · 0 comments

Comments

@davidbarratt
Copy link
Member

The locale that is set is not necessarily the language of the message that is returned. It might be helpful to return the language that was selected (maybe a new method that returns an object consisting of the message text and the language the message is in?). This way the HTML lang attribute can be set appropriately. What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidbarratt