-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of errors when printing #297
Comments
We're aware of some issues with printing, but they seem to vary greatly between browsers. |
I tried out the page-break-inside property in Firefox, but it doesn't seem to have any effect. I've created a pull request which resolves the issues with the header, and will have another go at image floating later. |
As for page-break-inside, there are some issues applying it directly to an image. You will need to wrap the image and apply it to the container. E.g. |
I've updated the comment to include fixes that needs to be done. The removal of the headers makes it seem that images does not break on pages, but I think a bit more testing of this would be good. Update: As pointed out before, the images still break in firefox :/ |
Has this been fixed by the recent updates to print styling? |
I would suppose there will be fewer issues now since we pack more content on each page, but we still haven't done anything in particular to ensure nice floating of images between page breaks. |
Removing display:block from Other than that, it looks good. |
I'll look into to the block-display, and see if we can make that work. And negative margins can be removed on print, so I'll do that. |
Tried with this page: https://www.wikipendium.no/TI%C3%984146_Finance (on this revision https://www.wikipendium.no/TI%C3%984146_Finance/history/3052/ )
List of TODOs:
First page:
Two other pages:
The text was updated successfully, but these errors were encountered: