Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky footer does not support dynamic footer height #349

Open
sigvef opened this issue May 24, 2015 · 5 comments
Open

Sticky footer does not support dynamic footer height #349

sigvef opened this issue May 24, 2015 · 5 comments

Comments

@sigvef
Copy link
Collaborator

sigvef commented May 24, 2015

No description provided.

@cristeahub cristeahub changed the title sticky footer does not support dynamic foooter height Sticky footer does not support dynamic footer height May 25, 2015
@cristeahub
Copy link
Member

What is the problem with this?

@sigvef
Copy link
Collaborator Author

sigvef commented May 25, 2015

I created this issue as a reaction to #348.

@cristeahub
Copy link
Member

I know, but I don't see what's the problem with being bound to a fixed-height footer. Is it for mobile?

@sigvef
Copy link
Collaborator Author

sigvef commented May 25, 2015

One problem is that the next time we want to change the footer content, we're going to forget to change the footer height again, breaking layout.

@sigvef
Copy link
Collaborator Author

sigvef commented May 25, 2015

Another is that having a fixed height footer is a hack, and will invariably break for some obscure browser configuration. One such configuration is on my screen with the page zoomed out quite a bit (see image, notice the scroll bar present). Other such configurations may be different font renderers on different platforms, different dpi settings for rendering form widgets, and more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants