Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some diffs are suboptimal #407

Open
iver56 opened this issue Sep 23, 2015 · 5 comments
Open

Some diffs are suboptimal #407

iver56 opened this issue Sep 23, 2015 · 5 comments

Comments

@iver56
Copy link
Contributor

iver56 commented Sep 23, 2015

This diff could be better

diff

Might be related to #379

@stianjensen
Copy link
Member

How would the optimal diff look in this case?

@cristeahub
Copy link
Member

This reminds me of how git diffs look !

@stianjensen
Copy link
Member

Yup, git has different diff algorithms.

One is the fast one (which is default) and produces similar results to this.

Another is the 'patience' diff, which I believe is a little slower, but might handle situations like this better.

@iver56
Copy link
Contributor Author

iver56 commented Sep 24, 2015

@stianjensen A better diff could look like this:
diff_improved

@stianjensen
Copy link
Member

I think this might probably be the same issue. What's actually happened here is that the 'by' has been removed.

screenshot 2015-12-01 16 02 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants