[Issue_183][WFLY-19397] Add a Jakarta Data TCK runner #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstansberry
force-pushed
the
Issue_183
branch
from
d301e9f
to
a82926a
Compare
bstansberry
force-pushed
the
Issue_183
branch
from
a82926a
to
993b3a6
Compare
jamezp
reviewed
Oct 24, 2024
| <version.org.jboss.arquillian.jakarta>10.0.0.Final</version.org.jboss.arquillian.jakarta> | ||
| <version.org.jboss.logging.jboss-logging>3.6.1.Final</version.org.jboss.logging.jboss-logging> | ||
| <version.org.jboss.shrinkwrap.shrinkwrap>1.2.6</version.org.jboss.shrinkwrap.shrinkwrap> | ||
| <version.org.junit>5.10.2</version.org.junit> |
| <properties> | ||
| <antlr.version>4.13.1</antlr.version> | ||
| <arquillian.version>1.8.0.Final</arquillian.version> | ||
| <junit.version>5.10.2</junit.version> |
|
|
||
| <properties> | ||
| <antlr.version>4.13.1</antlr.version> | ||
| <arquillian.version>1.8.0.Final</arquillian.version> |
There was a problem hiding this comment.
We should probably use 1.9.1.Final and add a dependency for arquillian-jakarta here.
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
| package ee.jakarta.tck.data.tools.annp; |
There was a problem hiding this comment.
Are we allowed to use this package name?
| <feature-pack> | ||
| <groupId>${wildfly.feature.pack.groupId}</groupId> | ||
| <artifactId>${wildfly.feature.pack.artifactId}</artifactId> | ||
| <version>${version.org.wildfly.wildfly}</version> |
There was a problem hiding this comment.
FWIW if we leave the version.org.wildfly.wildfly property empty and use a channel, we don't have to upgrade the version for every new release.
| @@ -0,0 +1,74 @@ | |||
| package org.hibernate.data.tck.ext; | |||
There was a problem hiding this comment.
This feels like an odd package name here.
| @@ -0,0 +1,14 @@ | |||
| package org.hibernate.data.tck.ext; | |||
There was a problem hiding this comment.
This feels like an odd package name here.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package embedded; |
There was a problem hiding this comment.
This feels like an odd package name here.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package embedded; |
There was a problem hiding this comment.
This feels like an odd package name here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #183
My (slightly modified from what's currently pushed) branch for wildfly/wildfly#18227 passes, both when pointing at an existing WildFly Preview build via -Djboss.home=/the/path and when using -Dversion.org.wildfly.wildfly=34.0.0.Beta1-SNAPSHOT and provisioning a server with the proposed 'jakarta-layer' layer.