Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update git sync scripts with url redacted #5008

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

HugoCasa
Copy link
Contributor

@HugoCasa HugoCasa commented Jan 3, 2025

Important

Update git sync script paths and URLs to latest versions in hubPaths.json and +page.svelte.

  • Paths Update:
    • Update gitSync and gitSyncTest paths in hubPaths.json to new versions.
  • UI Update:
    • Update script version URLs in +page.svelte for git sync alerts to reflect the latest version.

This description was created by Ellipsis for 50690de. It will automatically update as commits are pushed.

@HugoCasa HugoCasa requested a review from rubenfiszel as a code owner January 3, 2025 14:43
@HugoCasa HugoCasa changed the title feat: updaet git sync scripts with url redacted feat: update git sync scripts with url redacted Jan 3, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 50690de in 50 seconds

More details
  • Looked at 43 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/routes/(root)/(logged)/workspace_settings/+page.svelte:1477
  • Draft comment:
    The href attribute has been updated, but the text inside the anchor tag still references the old version. Consider updating the text to match the new version.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment appears to be incorrect. Looking at the diff, both href attributes were updated from "5813" to "9014", but the text content of the anchor tags is "{gitSyncRepository.script_path}" and "{latestGitSyncHubScript}" respectively - these are template variables, not hardcoded version numbers. The comment is making an incorrect assumption about what's displayed in the text content.
    Could there be some context I'm missing about how these template variables are rendered? Could the variables still contain old version numbers?
    No - looking at the code, gitSyncRepository.script_path and latestGitSyncHubScript are variables that would be updated together with the href changes. The comment is fundamentally misunderstanding the template structure.
    The comment should be deleted as it is based on an incorrect understanding of the code and makes a false assumption about hardcoded version numbers in the text content.

Workflow ID: wflow_9JAWBT5uW34SzxKX


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 50690de
Status: ✅  Deploy successful!
Preview URL: https://2bb34327.windmill.pages.dev
Branch Preview URL: https://hc-update-git-sync-scripts-u.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit bbf7fd6 into main Jan 3, 2025
3 checks passed
@rubenfiszel rubenfiszel deleted the hc/update-git-sync-scripts-url-redacted branch January 3, 2025 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants