Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding jaeger otel example + small typos in instance settings #5009

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

alpetric
Copy link
Contributor

@alpetric alpetric commented Jan 3, 2025

Important

Adds Jaeger OpenTelemetry example and fixes typos in instance settings.

  • New Example:
    • Adds otel-tracing-jaeger example with README.md, docker-compose.yml, jaeger-config.yaml, and prometheus-config.yaml for setting up Jaeger with OpenTelemetry.
  • Frontend Changes:
    • Fixes typo in InstanceSetting.svelte ("peridically" to "periodically").
    • Removes duplicate text in InstanceSetting.svelte.
    • Updates instanceSettings.ts to open links in a new tab.

This description was created by Ellipsis for 7e162f8. It will automatically update as commits are pushed.

@alpetric alpetric requested a review from rubenfiszel as a code owner January 3, 2025 14:46
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7e162f8 in 19 seconds

More details
  • Looked at 373 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/lib/components/InstanceSetting.svelte:515
  • Draft comment:
    Typo in the word 'periodically'.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The comment is about a typo in the word 'periodically'.
2. frontend/src/lib/components/InstanceSetting.svelte:550
  • Draft comment:
    Duplicate phrase 'Commit max batch size'.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The comment is about a duplicate phrase in the label text.

Workflow ID: wflow_vXO4wPjPvonyzgN1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2025

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: ecf59be
Status:⚡️  Build in progress...

View logs

@rubenfiszel rubenfiszel merged commit 736e241 into main Jan 3, 2025
6 of 7 checks passed
@rubenfiszel rubenfiszel deleted the alp/otel_example branch January 3, 2025 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants