Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mysql/rust decimal build #5010

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

HugoCasa
Copy link
Contributor

@HugoCasa HugoCasa commented Jan 3, 2025

Important

Add rust_decimal feature to mysql_async and update Cargo.lock to fix MySQL/Rust decimal build issue.

  • Dependencies:
    • Add rust_decimal feature to mysql_async in Cargo.toml.
    • Update Cargo.lock to include rust_decimal dependency.

This description was created by Ellipsis for 926b345. It will automatically update as commits are pushed.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 926b345
Status: ✅  Deploy successful!
Preview URL: https://04101171.windmill.pages.dev
Branch Preview URL: https://hc-fix-rust-decimal-mysql-bu.windmill.pages.dev

View logs

@HugoCasa HugoCasa marked this pull request as ready for review January 3, 2025 17:49
@HugoCasa HugoCasa requested a review from rubenfiszel as a code owner January 3, 2025 17:49
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 926b345 in 14 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. backend/Cargo.toml:263
  • Draft comment:
    The addition of the rust_decimal feature to mysql_async is consistent with the PR's intent to fix the MySQL/Rust decimal build. Ensure that this feature is necessary for your use case.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR adds the rust_decimal feature to the mysql_async dependency in Cargo.toml. This change is consistent with the PR title and description, which aims to fix the build for MySQL/Rust decimal. The addition of rust_decimal in Cargo.lock is also consistent with this change. No issues found.
2. backend/Cargo.lock:5322
  • Draft comment:
    The addition of rust_decimal in Cargo.lock is consistent with the changes in Cargo.toml. Ensure that this dependency is necessary for your use case.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The addition of rust_decimal in Cargo.lock is consistent with the changes in Cargo.toml. This ensures that the dependency is correctly included in the build.

Workflow ID: wflow_m3oBkgdUtLPXWibN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit e8fcea2 into main Jan 3, 2025
7 checks passed
@rubenfiszel rubenfiszel deleted the hc/fix-rust-decimal-mysql-build branch January 3, 2025 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants