interactive slack approvals: more improvements / nits

[alpetric]

Important

Renamed dynamic_enum_json to dynamic_enums_json across backend and client code, updating related documentation and function calls.

• Renaming:
  • Rename dynamic_enum_json to dynamic_enums_json in openapi.yaml, slack_approvals.rs, client.py, and client.ts.
• Documentation:
  • Update docstrings in client.py for request_interactive_slack_approval() to reflect parameter rename.
  • Update comments in client.ts for requestInteractiveSlackApproval() to reflect parameter rename.
• Code Updates:
  • Update function calls and parameter usage in slack_approvals.rs to use dynamic_enums_json.
  • Update function calls and parameter usage in client.py and client.ts to use dynamic_enums_json.

^{This description was created by for e2eee35. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to ccdd3ef in 3 minutes and 24 seconds

More details

• Looked at 355 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. backend/windmill-api/src/slack_approvals.rs:248

• Draft comment:
  The debug log message should be updated to reflect the new parameter name for consistency.

tracing::debug!("Dynamic enums json: {:#?}", dynamic_enums_json);

• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR changes the parameter name from dynamic_enum_json to dynamic_enums_json in multiple places. However, the debug log message still uses the old name Dynamic enum json. This should be updated to reflect the new parameter name for consistency and clarity.

2. backend/windmill-api/src/slack_approvals.rs:895

• Draft comment:
  The debug log message should be updated to reflect the new parameter name for consistency.

tracing::debug!("Dynamic enums json: {:#?}", dynamic_enums_json);

• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR changes the parameter name from dynamic_enum_json to dynamic_enums_json in multiple places. However, the debug log message still uses the old name Dynamic enum json. This should be updated to reflect the new parameter name for consistency and clarity.

Workflow ID: wflow_RFLOW2JplR9vTqGX

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[cloudflare-workers-and-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	e2eee35
Status:	✅  Deploy successful!
Preview URL:	https://71716d7d.windmill.pages.dev
Branch Preview URL:	https://alp-slack-docks.windmill.pages.dev

View logs

[ellipsis-dev]

👍 Looks good to me! Incremental review on e2eee35 in 25 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_HSle6RKNCuW6BuqU

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.