Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump uv version to 0.5.15 #5030

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Bump uv version to 0.5.15 #5030

merged 2 commits into from
Jan 9, 2025

Conversation

pyranota
Copy link
Collaborator

@pyranota pyranota commented Jan 8, 2025

Important

Update uv version to 0.5.15 and adjust installation path in three Dockerfiles.

  • Dockerfile Changes:
    • Update uv version to 0.5.15 in Dockerfile, DockerfileSlim, and DockerfileSlimEe.
    • Modify mv command path from /root/.cargo/bin/uv to /root/.local/bin/uv in all three Dockerfiles.

This description was created by Ellipsis for 1766563. It will automatically update as commits are pushed.

Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2025

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1766563
Status:⚡️  Build in progress...

View logs

@pyranota pyranota marked this pull request as ready for review January 9, 2025 10:50
@pyranota pyranota requested a review from rubenfiszel as a code owner January 9, 2025 10:50
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1766563 in 9 seconds

More details
  • Looked at 41 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. Dockerfile:162
  • Draft comment:
    Ensure that the path /root/.local/bin/uv is correct for the new version of UV. If the path is incorrect, it may lead to runtime errors. This change is also present in docker/DockerfileSlim and docker/DockerfileSlimEe.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR updates the version of UV being installed and changes the path from where the UV binary is moved. This change is consistent across all Dockerfiles in the PR.

Workflow ID: wflow_HnQ4BpVbwo1ChXQ3


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit 91257e5 into main Jan 9, 2025
8 of 9 checks passed
@rubenfiszel rubenfiszel deleted the bump_uv branch January 9, 2025 10:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants