Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhel image build workaround #5091

Merged
merged 5 commits into from
Jan 17, 2025
Merged

rhel image build workaround #5091

merged 5 commits into from
Jan 17, 2025

Conversation

alpetric
Copy link
Contributor

@alpetric alpetric commented Jan 17, 2025

  • skip chef (probably due to some windmill binary caching)
  • for now comment out arm build (shrink/actions-docker-extract@v3 fails for arm)

Important

Temporarily disable ARM64 build steps and skip cargo chef cook in RHEL image build due to caching and extraction issues.

  • Workflow Adjustments:
    • Comment out ARM64 extraction and artifact upload steps in build-publish-rh-image.yml due to shrink/actions-docker-extract@v3 failure.
  • Dockerfile Changes:
    • Add perl-FindBin and perl-IPC-Cmd to yum install in Dockerfile.
    • Comment out cargo chef cook step in Dockerfile to skip chef due to caching issues.

This description was created by Ellipsis for 8642396. It will automatically update as commits are pushed.

@alpetric alpetric requested a review from rubenfiszel as a code owner January 17, 2025 18:45
Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 158e6c1
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8642396 in 31 seconds

More details
  • Looked at 64 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .github/workflows/build-publish-rh-image.yml:100
  • Draft comment:
    Consider adding a comment explaining that the ARM64 build steps are commented out temporarily due to issues with shrink/actions-docker-extract@v3, and should be revisited once the issue is resolved.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR comments out the ARM64 build steps due to a failure in the shrink/actions-docker-extract@v3 action. This is a temporary workaround, but it should be noted in the comments that this is a temporary measure and should be revisited once the issue is resolved.
2. docker/RHEL9/Dockerfile:66
  • Draft comment:
    Consider adding a comment explaining that the cargo chef cook command is commented out temporarily, and should be revisited once the issue is resolved.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR comments out the cargo chef cook command in the Dockerfile. This might be a temporary workaround, and it should be noted in the comments that this is a temporary measure and should be revisited once the issue is resolved.

Workflow ID: wflow_ASo0UdkyUtjZPY3x


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit 6f469ac into main Jan 17, 2025
1 of 2 checks passed
@rubenfiszel rubenfiszel deleted the alp/buildrhel_no_chef branch January 17, 2025 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants