Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to bun.lock #5112

Merged
merged 7 commits into from
Jan 22, 2025
Merged

feat: Migrate to bun.lock #5112

merged 7 commits into from
Jan 22, 2025

Conversation

pyranota
Copy link
Collaborator

@pyranota pyranota commented Jan 21, 2025

(In backwards compatible way)

Read more: https://bun.sh/blog/bun-lock-text-lockfile


Important

Migrate from bun.lockb to bun.lock in a backwards-compatible way, updating lock file handling in bun_executor.rs and run.bun.config.proto.

  • Behavior:
    • Migrate from bun.lockb to bun.lock in run.bun.config.proto and bun_executor.rs.
    • Update split_lockfile() to handle both bun.lock and bun.lockb formats.
    • Modify install_bun_lockfile() to use --save-text-lockfile.
  • Functions:
    • Update split_lockfile() to return an additional boolean indicating if the lock file is binary.
    • Rename write_lockb() to write_lock() and update its logic to handle both text and binary lock files.
  • Configuration:
    • Add mount for bun.lock in run.bun.config.proto.

This description was created by Ellipsis for 3e24c13. It will automatically update as commits are pushed.

Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2025

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e24c13
Status: ✅  Deploy successful!
Preview URL: https://11295b5f.windmill.pages.dev
Branch Preview URL: https://bun-lock-migration.windmill.pages.dev

View logs

@pyranota pyranota marked this pull request as ready for review January 21, 2025 20:04
@pyranota pyranota requested a review from rubenfiszel as a code owner January 21, 2025 20:04
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3e24c13 in 2 minutes and 9 seconds

More details
  • Looked at 223 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. backend/windmill-worker/src/bun_executor.rs:924
  • Draft comment:
    The error message should be updated to reflect the new split pattern for bun.lock files.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. backend/windmill-worker/src/bun_executor.rs:1615
  • Draft comment:
    The error message should be updated to reflect the new split pattern for bun.lock files.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_zNlU76Hj6lxYekAe


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel changed the title bun: Migrate to bun.lock feat: Migrate to bun.lock Jan 22, 2025
@rubenfiszel rubenfiszel merged commit fcfad69 into main Jan 22, 2025
7 checks passed
@rubenfiszel rubenfiszel deleted the bun-lock-migration branch January 22, 2025 11:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants