-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate to bun.lock #5112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(In backwards compatible way) Read more: https://bun.sh/blog/bun-lock-text-lockfile
…l into bun-lock-migration
Deploying windmill with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 3e24c13 in 2 minutes and 9 seconds
More details
- Looked at
223
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. backend/windmill-worker/src/bun_executor.rs:924
- Draft comment:
The error message should be updated to reflect the new split pattern for bun.lock files. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. backend/windmill-worker/src/bun_executor.rs:1615
- Draft comment:
The error message should be updated to reflect the new split pattern for bun.lock files. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_zNlU76Hj6lxYekAe
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(In backwards compatible way)
Read more: https://bun.sh/blog/bun-lock-text-lockfile
Important
Migrate from
bun.lockb
tobun.lock
in a backwards-compatible way, updating lock file handling inbun_executor.rs
andrun.bun.config.proto
.bun.lockb
tobun.lock
inrun.bun.config.proto
andbun_executor.rs
.split_lockfile()
to handle bothbun.lock
andbun.lockb
formats.install_bun_lockfile()
to use--save-text-lockfile
.split_lockfile()
to return an additional boolean indicating if the lock file is binary.write_lockb()
towrite_lock()
and update its logic to handle both text and binary lock files.bun.lock
inrun.bun.config.proto
.This description was created by for 3e24c13. It will automatically update as commits are pushed.