Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links to deno.land/x/windmill #607

Open
ralphwest1 opened this issue May 12, 2024 · 2 comments
Open

Broken links to deno.land/x/windmill #607

ralphwest1 opened this issue May 12, 2024 · 2 comments

Comments

@ralphwest1
Copy link
Contributor

in file: docs/core_concepts/11_persistent_storage/within_windmill.mdx links to https://deno.land/x/windmill/mod.ts?s=setResource and https://deno.land/x/windmill/mod.ts?s=getResource are broken and don't work.

These are on line 158 and 159 of the file

157  - `setResource(value: any, path?: string, initializeToTypeIfNotExist?: string)`: which sets a resource at a given path. This is
158    equivalent to `setState` but allows you to set an arbitrary path and chose a type other than state if wanted. [See API](https://deno.land/x/windmill/mod.ts?s=setResource).
159  - `getResource(path: string)`: gets a resource at a given path. [See API](https://deno.land/x/windmill/mod.ts?s=getResource).

Not sure if this a temporary deno.land thing or if they should be updated to point at jsr.io.

I'm happy to file a pull request to update these links and any other broken deno.land links if you advise on where they should be pointing.

@rubenfiszel
Copy link
Contributor

Correct, we will indeed make jsr the new official documentation of the typescript client. We would welcome any PRs! Thanks a lot

@ralphwest1
Copy link
Contributor Author

No problem, When I have a little time, I'll submit a pull request to update all deno.land links on all pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants