Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Transitions - Docs could be clearer about where to attach the transition directive #12859

Closed
1 task
dreamstar-enterprises opened this issue Dec 30, 2024 · 1 comment
Labels
needs triage Issue needs to be triaged

Comments

@dreamstar-enterprises
Copy link

dreamstar-enterprises commented Dec 30, 2024

Astro Info

5.1.1.

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

I think the docs could be clearer about this.
For example:

This works

<!--footer-->
<footer class="mt-auto bg-theme-selected-footer-background" transition:persist>

But if I take the transition:persist and put it in the Astro component (i.e. the wrapper), it does not work

<Footer transistion:persist />

Perhaps not a bug, but if not, docs could be a little bit clearer

What's the expected result?

See above

Link to Minimal Reproducible Example

seeabove

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 30, 2024
@martrapp
Copy link
Member

Hi @dreamstar-enterprises 👋🏼, yes!

If the Footer component does not handle transition:persist, it will just be ignored.

Would you please open a PR on the docs repository to improve the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants