You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When tally execution panics, the data request is resolved as "RadError::Unknown". I would expect a similar behavior if the retrieval or aggregation scripts panic, but that's not the case. Instead of commiting a "RadError::Unknown", nodes do not commit anything. So most probably the data request will resolve with an "insufficient commits" error.
This is similar to #2306, but this behavior has always been like that, ever since the creation of the RadManager. This is the piece of code that decides to ignore this case:
The behavior is different for tallies vs. commits because data requests need to be eventually tallied, so there shouldn't be such a thing as refraining from tallying.
When tally execution panics, the data request is resolved as "RadError::Unknown". I would expect a similar behavior if the retrieval or aggregation scripts panic, but that's not the case. Instead of commiting a "RadError::Unknown", nodes do not commit anything. So most probably the data request will resolve with an "insufficient commits" error.
This is similar to #2306, but this behavior has always been like that, ever since the creation of the
RadManager
. This is the piece of code that decides to ignore this case:witnet-rust/node/src/actors/chain_manager/mining.rs
Lines 570 to 574 in 2fa9a2f
So not sure if this is intended or not. But we could even have nodes reporting the panic message, perhaps as a new RadError.
The text was updated successfully, but these errors were encountered: